Using/Teaching zone.exo instead of Far
#89
Draft
+2,598
−2,704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
requested changes
Aug 6, 2024
contract/package.json
Outdated
| "@agoric/zoe": "^0.26.3-u12.0", | ||
| "@agoric/zone": "^0.3.0-u16.1", |
There was a problem hiding this comment.
What impact does this have on the contract bundle size? Does it introduce duplicate dependencies?
Other dependencies in this dapp (zoe, ertp) look like they're from u12. IME, mixing u12 and u16 is asking for trouble.
I know dapp-agoric-basics uses u14: Agoric/dapp-agoric-basics@817bc8a
Are you familiar with the fragility of dependency versions?
- bundle contains duplicated modules based on duplicated packages in node_modules agoric-sdk#8621
- fix: contract bundles have duplicate dependencies #34
- Test that compressed contract bundles are less than 1MB #36
- cannot publish inter protocol bundles over 1M due to max_tx_bytes tendermint config agoric-sdk#7501
It looks like @Jovonni managed to use u16 in dapp-orchestration-basics, though it took some troubleshooting. See item 9 in particular.
ci: restore `yarn test`, excluding e2e; restore node LTS
Co-authored-by: Dan Connolly <[email protected]>
Co-authored-by: Dan Connolly <[email protected]>
Co-authored-by: Dan Connolly <[email protected]>
Co-authored-by: Dan Connolly <[email protected]>
Co-authored-by: Dan Connolly <[email protected]>
Co-authored-by: Dan Connolly <[email protected]>
…ric/dapp-offer-up into ms/replace-Far-with-zone.exo
|
I gather recent symptoms include a problem when starting the ui: a blank page and a console error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to contract file (and related deps to package.json) to use
zone.exoto replaceFar. Note that this is only for teaching purpose at the moment and does not make resulting contract upgradable becausezoneandbaggageare created insidestartfunction. The upgradability will require changingstartsignature which I am avoiding at the moment.Ref(s):
Agoric/documentation#1033